test: retry transiently failed Actor builds in e2e make_actor fixture#970
Merged
Conversation
vdusek
added
adhoc
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #970 +/- ##
==========================================
- Coverage 89.91% 89.88% -0.04%
==========================================
Files 49 49
Lines 3085 3085
==========================================
- Hits 2774 2773 -1
- Misses 311 312 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Pijukatel
approved these changes
Jun 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The E2E test
test_custom_pipeline_spiderfailed in this CI run because the Actor build on the platform finished with statusFAILED. This was a platform-side transient: the same commit passed the full E2E job on Python 3.11, and in the failing job the four sibling Scrapy tests built Actors with identical build inputs (same Dockerfile andrequirements.txt) successfully. The build does not depend on the test's source files (they are only copied into the image), but it does run network-dependent steps (apt-get update,pip install --force-reinstall), which occasionally fail.The
make_actorfixture now retries a failed platform build once before asserting, which covers this flake class for all E2E tests. A deterministic build break still fails after two attempts, and the failed build ID is printed for debugging.